inspector: roll inspector_protocol to match v8's #56649
Open
+10,735
−10,752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the inspector_protocol/roll.py to fit node source directory structure. `roll.py` reads the `deps/v8/thrid_party/inspector_protocol/README.v8` to get the revision of the inspector_protocol that V8 depends on, and updates the local version to match. V8's copy of inspector_protocol modifies the namespace of `crdtp` library and does not export the symbols. So it can not be used outside of V8.
|
Review requested:
|
nodejs-github-bot
added
dependencies
legendecas
added
the
inspector
legendecas
force-pushed
the
inspector/roll-protocol
branch
2 times, most recently
from
3e5e140 to
a9069ea
Compare
Roll the inspector_protocol library to match V8's inspector_protocol revision. Update the node inspector to use the new `crdtp` protocol library.
The `crdtp` library in the inspector_protocol is compiled as a library and linked to the node executable.
legendecas
force-pushed
the
inspector/roll-protocol
branch
from
a9069ea to
be85fe3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56649 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.02%
==========================================
Files 662 663 +1
Lines 191883 191946 +63
Branches 36941 36939 -2
==========================================
+ Hits 171196 171216 +20
- Misses 13536 13560 +24
- Partials 7151 7170 +19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools: update inspector_protocol roller
Fix the inspector_protocol/roll.py to fit node source directory
structure.
roll.pyreads thedeps/v8/thrid_party/inspector_protocol/README.v8to get the revision of the inspector_protocol that V8 depends on, and
updates the local version to match.
V8's copy of inspector_protocol modifies the namespace of
crdtplibrary and does not export the symbols. So it can not be used outside
of V8.
inspector: roll inspector_protocol
Roll the inspector_protocol library to match V8's inspector_protocol
revision.
Update the node inspector to use the new
crdtpprotocol library.deps: move inspector_protocol to deps
The
crdtplibrary in the inspector_protocol is compiled as a libraryand linked to the node executable.