Skip to content

assert: move CallTracker to EOL #58006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

assert: move CallTracker to EOL #58006

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 24, 2025

The assert.CallTracker API has been deprecateed since v20. The node:test mock.fn API provides a better alternative for the functionality.

@jasnell jasnell added assert Issues and PRs related to the assert subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Apr 24, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 24, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
cjihrig
cjihrig approved these changes Apr 24, 2025
View reviewed changes
mcollina
mcollina approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (49bb0ae) to head (cd5f99b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58006      +/-   ##
==========================================
- Coverage   90.18%   90.16%   -0.03%     
==========================================
  Files         630      629       -1     
  Lines      186390   186234     -156     
  Branches    36597    36561      -36     
==========================================
- Hits       168105   167918     -187     
- Misses      11090    11114      +24     
- Partials     7195     7202       +7
Files with missing lines Coverage Δ
lib/assert.js 99.52% <100.00%> (-0.01%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas
Copy link
Member

Every time a property is moved to EOL, should CITGM be run?

@jasnell
assert: move CallTracker to EOL
cd5f99b 
The `assert.CallTracker` API has been deprecateed since v20. The
`node:test` `mock.fn` API provides a better alternative for the
functionality.
@jasnell jasnell force-pushed the jasnell/eol-calltracker branch from 6e88ac6 to cd5f99b Compare April 27, 2025 14:33
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/66484/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3584/

@jasnell jasnell requested review from anonrig and mcollina April 27, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@anonrig anonrig Awaiting requested review from anonrig

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @bjohansebas @mcollina @anonrig @cjihrig @JakobJingleheimer @geeksilva97