-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
esm: graduate import.meta properties #58011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark as no longer experimental: * `import.meta.resolve()` * `import.meta.dirname` * `import.meta.filename`
Review requested:
|
anonrig
approved these changes
Apr 24, 2025
marco-ippolito
approved these changes
Apr 24, 2025
guybedford
approved these changes
Apr 25, 2025
aduh95
reviewed
Apr 25, 2025
aduh95
reviewed
Apr 25, 2025
mcollina
approved these changes
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jasnell
commented
Apr 27, 2025
jasnell
commented
Apr 27, 2025
jasnell
commented
Apr 27, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
jasnell
commented
Apr 27, 2025
jasnell
commented
Apr 27, 2025
mcollina
approved these changes
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
GeoffreyBooth
approved these changes
Apr 27, 2025
jasnell
added a commit
that referenced
this pull request
Apr 27, 2025
Mark as no longer experimental: * `import.meta.dirname` * `import.meta.filename` PR-URL: #58011 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Landed in c1b15a4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark as no longer experimental:
reverted... left as experimental per feedbackimport.meta.resolve()
import.meta.dirname
import.meta.filename