Skip to content

esm: graduate import.meta properties #58011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 24, 2025

Mark as no longer experimental:

  • import.meta.resolve() reverted... left as experimental per feedback
  • import.meta.dirname
  • import.meta.filename

Mark as no longer experimental:

* `import.meta.resolve()`
* `import.meta.dirname`
* `import.meta.filename`
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 24, 2025
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 24, 2025
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Antoine du Hamel <[email protected]>
@jasnell jasnell requested review from mcollina, aduh95 and anonrig April 27, 2025 14:11
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasnell added a commit that referenced this pull request Apr 27, 2025
Mark as no longer experimental:

* `import.meta.dirname`
* `import.meta.filename`

PR-URL: #58011
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2025

Landed in c1b15a4

@jasnell jasnell closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants