-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
test: fix URL v8 fast api tests #58021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58021 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 630 630
Lines 186158 186158
Branches 36484 36475 -9
==========================================
- Hits 168067 168051 -16
- Misses 10974 10988 +14
- Partials 7117 7119 +2 🚀 New features to boost your workflow:
|
// Only javascript methods can be optimized through %OptimizeFunctionOnNextCall | ||
// This is why we surround the C++ method we want to optimize with a JS function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is worthy to update the fast api docs to add this note, and maybe the exception when it's called with C++, just to be easy to find the docs when someone receive this error
Closing in favor of #58023 |
Fixes v8 fast api tests in test-whatwg-url-canparse.js