Skip to content

test: add fast api tests for getLibuvNow() #58022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

test: add fast api tests for getLibuvNow() #58022

merged 1 commit into from
Apr 27, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 25, 2025

Adds a test for the v8 fast api we use for getLibuvNow() method.

@anonrig anonrig requested review from jasnell and targos April 25, 2025 14:25
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Apr 25, 2025
@anonrig anonrig force-pushed the yagiz/add-libuv-fast-api branch from 1171c3a to ee7237f Compare April 25, 2025 14:25
@anonrig anonrig changed the title Yagiz/add libuv fast api test: add fast api tests for getLibuvNow() Apr 25, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (9cc0195) to head (5b01f13).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58022      +/-   ##
==========================================
- Coverage   90.28%   90.27%   -0.01%     
==========================================
  Files         630      630              
  Lines      186158   186328     +170     
  Branches    36484    36503      +19     
==========================================
+ Hits       168067   168205     +138     
- Misses      10974    11004      +30     
- Partials     7117     7119       +2
Files with missing lines Coverage Δ
src/timers.cc 88.69% <100.00%> (+2.60%) ⬆️
src/timers.h 100.00% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66459/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66461/

@anonrig anonrig force-pushed the yagiz/add-libuv-fast-api branch from ee7237f to 5b01f13 Compare April 26, 2025 21:02
@anonrig anonrig requested a review from H4ad April 26, 2025 22:48
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66477/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-bot nodejs-github-bot merged commit 145c6a2 into nodejs:main Apr 27, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 145c6a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@H4ad H4ad H4ad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @jasnell @H4ad @aduh95