lib: improve error handling in Buffer.concat #59592
Open
+97
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
SeokhunEom
force-pushed
the
buffer-concat-error
branch
2 times, most recently
from
18b7d69 to
553175d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59592 +/- ##
==========================================
+ Coverage 89.82% 89.85% +0.02%
==========================================
Files 666 667 +1
Lines 195337 196145 +808
Branches 38345 38512 +167
==========================================
+ Hits 175463 176246 +783
- Misses 12329 12364 +35
+ Partials 7545 7535 -10
🚀 New features to boost your workflow:
|
jasnell
reviewed
Aug 23, 2025
| throw new ERR_INVALID_ARG_TYPE( | ||
| `list[${i}]`, ['Buffer', 'Uint8Array'], list[i]); | ||
| throw new ERR_INVALID_ARRAY_ELEMENT_TYPE( | ||
| 'list', i, ['Buffer', 'Uint8Array'], list[i]); |
There was a problem hiding this comment.
I could imagine this error to be useful for other container types too (e.g. sets)... maybe the name shouldn't be specific to array? ERR_INVALID_CONTAINER_ELEMENT_TYPE?
There was a problem hiding this comment.
I updated to more general error type ERR_INVALID_CONTAINER_ELEMENT_TYPE.
Thank you for comment.
|
/cc @BridgeAR since it's your todo comment being addressed here :-) |
- Replace ERR_INVALID_ARG_TYPE with ERR_INVALID_CONTAINER_ELEMENT_TYPE for clarity in error messages - Update test-buffer-concat.js with new error code and message format - Add new error ERR_INVALID_CONTAINER_ELEMENT_TYPE in lib/internal/errors.js - Add document for ERR_INVALID_CONTAINER_ELEMENT_TYPE in doc/api/errors.md
SeokhunEom
force-pushed
the
buffer-concat-error
branch
from
553175d to
2811ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling in
Buffer.concat. I replaced the genericERR_INVALID_ARG_TYPEwith the more specificERR_INVALID_CONTAINER_ELEMENT_TYPEto provide a clearer error message. To make this change, I updated the test code intest-buffer-concat.jsto check for the new error code and message format. And also added theERR_INVALID_CONTAINER_ELEMENT_TYPEerror type tolib/internal/errors.jsand included documentation for it indoc/api/errors.md. This error type can be used for checking elements in continaers.I think this is samver-major PR.