-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Revert "test: ensure message event fires in worker message port test" #60126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 9790315. Refs: nodejs#59952
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60126 +/- ##
=======================================
Coverage 88.52% 88.53%
=======================================
Files 703 703
Lines 207825 207825
Branches 40011 40007 -4
=======================================
+ Hits 183982 183989 +7
+ Misses 15864 15850 -14
- Partials 7979 7986 +7 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the GH web diff UI shows port1.on('message', () => {
on line 14, but the actual value on main
is
port1.on('message', common.mustCallAtLeast(() => { |
Landed in 985e2fb |
This reverts commit 9790315.
Refs: #59952