Skip to content

benchmark: allow boolean option values in createBenchmark #60129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

benchmark: allow boolean option values in createBenchmark #60129

wants to merge 2 commits into from
+29 −27

Conversation

SeokhunEom
Copy link
Contributor

@SeokhunEom SeokhunEom commented Oct 6, 2025 •
edited
Loading

  1. Change createBenchmark to also accept booleans options and update document about it.
  2. Use boolean values for randomUUID benchmark and deprecate benchmark instead of 0/1.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module. labels Oct 6, 2025
@SeokhunEom SeokhunEom force-pushed the benchmark-boolean-option branch 4 times, most recently from 5e643fc to bea0f69 Compare October 6, 2025 16:58
@SeokhunEom
benchmark: allow boolean option values
5f9d07f 
Change createBenchmark to also accept booleans.
Update writing-and-running-benchmarks.md and format the md.
@SeokhunEom
benchmark: use boolean options in benchmark tests
ad0c9ac 
Use boolean values for randomUUID benchmark and
deprecate benchmark instead of 0/1.
@SeokhunEom SeokhunEom force-pushed the benchmark-boolean-option branch from bea0f69 to ad0c9ac Compare October 7, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeokhunEom @nodejs-github-bot @RafaelGSS