Skip to content

Conversation

Renegade334
Copy link
Contributor

const session = require('http2').connect('http://localhost/')
session.ping(new Uint32Array(8), console.debug)

yields

  #  node[1898056]: static void node::http2::Http2Session::Ping(const v8::FunctionCallbackInfo<v8::Value>&) at ../src/node_http2.cc:3227
  #  Assertion failed: (payload.length()) == (8)

IOT instruction (core dumped)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 6, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (b757a8f) to head (b0a2c8c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60135      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         703      703              
  Lines      207804   207804              
  Branches    40005    40006       +1     
==========================================
- Hits       183989   183952      -37     
- Misses      15817    15866      +49     
+ Partials     7998     7986      -12     
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.20% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@mcollina mcollina added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x and removed request-ci Add this label to start a Jenkins CI on a PR. needs-ci PRs that need a full CI run. labels Oct 7, 2025
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-bot nodejs-github-bot merged commit 535efea into nodejs:main Oct 8, 2025
85 of 86 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 535efea

@Renegade334 Renegade334 deleted the http2-ping-byte-length branch October 9, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants