chore: store source files in src/ #7949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes package source layouts by moving all primary code into src/ directories and updating related configurations, exports, and documentation.
- Updates TypeScript and turborepo configs to only include
src/paths - Adjusts
package.jsonexports/imports to referencesrc/ - Revises docs, Stylelint, Crowdin, and CI workflows to use new
src/paths
Reviewed Changes
Copilot reviewed 12 out of 212 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/tsconfig.json | Changed include to only "src" |
| packages/ui-components/package.json | Updated exports/imports to "src/*" and removed files list |
| packages/ui-components/.stylelintrc.mjs | Pointed plugin path to #ui/stylelint/... |
| packages/i18n/turbo.json | Switched lint inputs from lib/**/* to src/**/* |
| packages/i18n/tsconfig.json | Changed include to only "src" |
| packages/i18n/src/index.mjs | Updated import paths and JSDoc references to ./ |
| packages/i18n/package.json | Reconfigured exports, main, and module to src/ |
| docs/downloads-page.md | Updated locales path to packages/i18n/src/locales |
| docs/creating-components.md | Adjusted example component path to include /src/ |
| docs/adding-pages.md | Updated docs references to new src/ locale paths |
| crowdin.yml | Changed translation source/target paths to src/ |
| .github/workflows/translations-pr-lint.yml | Updated CI lint paths for JSON to src/locales |
Comments suppressed due to low confidence (2)
packages/ui-components/package.json:12
- Removing the "files" array may cause unintended files (e.g., docs, configs, tests) to be published. Consider re-adding a whitelist of distributable files to keep the package bundle lean.
},
packages/ui-components/tsconfig.json:19
- [nitpick] By restricting
includeto onlysrc,.storybookTypeScript files are no longer covered by this config. If you still want to type-check Storybook code, consider adding a separate tsconfig or including that directory here.
"include": ["src"]
avivkeller
force-pushed
the
chore/src-directory
branch
from
9490693 to
7e5556b
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #7949 +/- ##
==========================================
+ Coverage 75.40% 75.42% +0.02%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 219
==========================================
+ Hits 6299 6301 +2
+ Misses 2053 2051 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
bjohansebas
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, we should (IMO) store all the source files of a given package in it's
src/directory. That should also make it easier to compile with TypeScript, since we only need to include thesrc/directory (rather than**/*.[...], and explicit excludes).