Revert "fix: fire close on failed WebSocket connection (#3566)"

This reverts commit 290e0e1.
nodejs · Sep 20, 2024 · 143fbfe · 143fbfe
1 parent 290e0e1
commit 143fbfe
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -537,14 +537,6 @@ class WebSocket extends EventTarget {
         message: reason
       })
     }
-
-    if (!this.#parser && !this.#handler.receivedClose) {
-      fireEvent('close', this, (type, init) => new CloseEvent(type, init), {
-        wasClean: false,
-        code: 1006,
-        reason
-      })
-    }
   }
 
   #onMessage (type, data) {

diff --git a/test/websocket/issue-3546.js b/test/websocket/issue-3546.js
@@ -5,7 +5,7 @@ const { WebSocket } = require('../..')
 const { tspl } = require('@matteo.collina/tspl')
 
 test('first error than close event is fired on failed connection', async (t) => {
-  const { completed, strictEqual } = tspl(t, { plan: 4 })
+  const { completed, strictEqual } = tspl(t, { plan: 2 })
   const ws = new WebSocket('ws://localhost:1')
 
   let orderOfEvents = 0