Skip to content

chore: guard client[kUrl] in closeClientIfUnused loop #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vctqs1 wants to merge 3 commits into from
+154 −2
Closed

chore: guard client[kUrl] in closeClientIfUnused loop #5532

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5795c04
chore: add null check for client URL in origin comparison
vctqs1 Jul 9, 2026
cc78087
chore: use optional chaining for client URL origin check
vctqs1 Jul 9, 2026
d0504a7
test(agent): cover missing kUrl cleanup paths
vctqs1 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dispatcher/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class Agent extends DispatcherBase {

let hasOrigin = false
for (const client of this[kClients].values()) {
if (client[kUrl].origin === dispatcher[kUrl].origin) {
if (client[kUrl]?.origin === dispatcher[kUrl].origin) {
hasOrigin = true
break
}
Expand Down
Loading