Skip to content

Conversation

nuke-web3
Copy link

Description

Updates runner to support Noir v1.0.0-beta.3 once noir-lang/noir-runner#2 is merged.

Problem*

Resolves #20

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@nuke-web3
Copy link
Author

nuke-web3 commented May 5, 2025

Running with the upstream PR's branch as a local path in Cargo.toml passes tests:

$ ./scripts/fuzz-test.sh

warning: Unsafe block must have a safety comment above it
   ┌─ src/sha256.nr:49:17
   │
49 │                 unsafe { build_msg_block(msg, message_size, msg_start) };
   │                 ------ The comment must start with the "Safety: " word
   │

warning: Unsafe block must have a safety comment above it
   ┌─ src/sha256.nr:75:17
   │
75 │                 unsafe { build_msg_block(msg, message_size, msg_start) };
   │                 ------ The comment must start with the "Safety: " word
   │

warning: Unsafe block must have a safety comment above it
    ┌─ src/sha256.nr:110:21
    │
110 │         msg_block = unsafe { attach_len_to_msg_block(msg_block, msg_byte_ptr, message_size) };
    │                     ------ The comment must start with the "Safety: " word
    │

   Compiling noir-runner v0.1.1 (/home/nuke/git/noir/runner)
   Compiling sha256 v0.1.0 (/home/nuke/git/noir/sha256)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 5.65s
     Running tests/differential.rs (target/debug/deps/differential-00d082b961ce810e)

running 4 tests
test test_prop_sha256_1 ... ok
test test_prop_sha256_200 ... ok
test test_prop_sha256_511 ... ok
test test_prop_sha256_512 ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.17s

warning: Unsafe block must have a safety comment above it
   ┌─ src/sha256.nr:49:17
   │
49 │                 unsafe { build_msg_block(msg, message_size, msg_start) };
   │                 ------ The comment must start with the "Safety: " word
   │

warning: Unsafe block must have a safety comment above it
   ┌─ src/sha256.nr:75:17
   │
75 │                 unsafe { build_msg_block(msg, message_size, msg_start) };
   │                 ------ The comment must start with the "Safety: " word
   │

warning: Unsafe block must have a safety comment above it
    ┌─ src/sha256.nr:110:21
    │
110 │         msg_block = unsafe { attach_len_to_msg_block(msg_block, msg_byte_ptr, message_size) };
    │                     ------ The comment must start with the "Safety: " word
    │

    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.18s
     Running tests/differential.rs (target/debug/deps/differential-00d082b961ce810e)

running 4 tests
test test_prop_sha256_1 ... ok
test test_prop_sha256_200 has been running for over 60 seconds
test test_prop_sha256_511 has been running for over 60 seconds
test test_prop_sha256_512 has been running for over 60 seconds
test test_prop_sha256_200 ... ok
test test_prop_sha256_512 ... ok
test test_prop_sha256_511 ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 280.74s

@nuke-web3 nuke-web3 changed the title Update to Noir v1.0.0 Update to Noir v1.0.0-beta.3 May 5, 2025
@nuke-web3 nuke-web3 marked this pull request as ready for review May 5, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 👀 To Triage
Development

Successfully merging this pull request may close these issues.

basic test fail for Noir 1.0
1 participant