CategoryService: cache full child categories & speed up breadcrumb via HashSet #7828
+308
−634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cached child categories as full Category objects instead of IDs to avoid extra DB lookups.
Replaced List with HashSet in breadcrumb building for O(1) lookups.
Motivation
Previously, category tree expansion and breadcrumb building triggered unnecessary DB queries and slow List.Contains checks on deep hierarchies.
Changes
Updated GetChildCategoryIdsAsync:
Cache now stores Dictionary<int, List> instead of Dictionary<int, List>.
Updated GetCategoryBreadCrumbAsync:
Use HashSet for alreadyProcessedCategoryIds.
Impact
Fewer database queries after cache warm-up.
Faster breadcrumb generation with reduced CPU overhead.
No changes in external behavior or APIs.
Testing
Verified via SQL logs: fewer DB queries after repeated category/breadcrumb requests.
UI results remain unchanged.
Risk / Compatibility
Low. Cache key unchanged.
Only internal CategoryService usage updated.