Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Nov 14, 2024

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85 branch 4 times, most recently from fcf7489 to 2f3320b Compare November 14, 2024 19:08
@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Nov 14, 2024

  1. The previously used Element Web 1.11.50 still works, but does not support the widget toggles (2f3320b).
  2. With Element Web 1.11.58, widget toggles are supported (9c0b116).
  3. The testing container does not build when using the latest Element (>= 1.11.84) (768e8c2): due to the absorption of the matrix-react-sdk into Element Web, some references in the modules have become invalid.
29.80 [webpack-cli] ModuleNotFoundError: Module not found: Error: Can't resolve 'matrix-react-sdk/src/MatrixClientPeg' in '/src/node_modules/@nordeck/element-web-guest-module/customisations'
29.80     at /src/node_modules/webpack/lib/Compilation.js:2109:28
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:908:13
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:333:22
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:512:22
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:150:10
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:775:25
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:992:8
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:1121:5
29.80     at /src/node_modules/neo-async/async.js:6883:13
29.80     at /src/node_modules/webpack/lib/NormalModuleFactory.js:1104:45
29.80     at finishWithoutResolve (/src/node_modules/enhanced-resolve/lib/Resolver.js:567:11)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:656:15
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
29.80     at /src/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:89:43
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
29.80     at /src/node_modules/enhanced-resolve/lib/forEachBail.js:39:13
29.80     at /src/node_modules/enhanced-resolve/lib/AliasPlugin.js:148:14
29.80     at next (/src/node_modules/enhanced-resolve/lib/forEachBail.js:35:3)
29.80     at forEachBail (/src/node_modules/enhanced-resolve/lib/forEachBail.js:49:9)
29.80     at /src/node_modules/enhanced-resolve/lib/AliasPlugin.js:61:5
29.80     at _next0 (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:8:1)
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
29.80     at /src/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:89:43
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
29.80     at /src/node_modules/enhanced-resolve/lib/Resolver.js:718:5
29.80     at eval (eval at create (/src/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
29.80     at /src/node_modules/enhanced-resolve/lib/DirectoryExistsPlugin.js:41:15
29.80     at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
29.80 resolve 'matrix-react-sdk/src/MatrixClientPeg' in '/src/node_modules/@nordeck/element-web-guest-module/customisations'
29.80   Parsed request is a module
29.80   using description file: /src/node_modules/@nordeck/element-web-guest-module/package.json (relative path: ./customisations)
29.80     Field 'matrix_src_browser' doesn't contain a valid alias configuration
29.80     Field 'browser' doesn't contain a valid alias configuration
29.80     resolve as module
29.80       /src/node_modules/@nordeck/element-web-guest-module/customisations/node_modules doesn't exist or is not a directory
29.80       looking for modules in /src/node_modules/@nordeck/element-web-guest-module/node_modules
29.80         /src/node_modules/@nordeck/element-web-guest-module/node_modules/matrix-react-sdk doesn't exist
29.80       /src/node_modules/@nordeck/node_modules doesn't exist or is not a directory
29.80       /src/node_modules/node_modules doesn't exist or is not a directory
29.80       looking for modules in /src/node_modules
29.80         /src/node_modules/matrix-react-sdk doesn't exist
29.80       /node_modules doesn't exist or is not a directory
  1. The container does build using Element Web <1.11.84, yet the tests fail - I'm guessing due to changes in Element UI (036b3f5).

@HarHarLinks HarHarLinks marked this pull request as ready for review November 15, 2024 14:00
@HarHarLinks HarHarLinks requested a review from a team November 15, 2024 14:00
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@HarHarLinks HarHarLinks merged commit 2fb0d13 into main Nov 15, 2024
@HarHarLinks HarHarLinks deleted the nic/feat/PX4-85 branch November 15, 2024 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants