Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BAOA to SGMCMC #119

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Add BAOA to SGMCMC #119

merged 6 commits into from
Feb 18, 2025

Conversation

SamDuffield
Copy link
Contributor

@SamDuffield SamDuffield commented Feb 7, 2025 •
edited
Loading

Adds the BAOA integrator to the SGMCMC suite.

As discussed in #62

@SamDuffield SamDuffield added the new method New algorithm label Feb 7, 2025
@SamDuffield SamDuffield changed the title Add BAOAB to SGMCMC Add BAOA to SGMCMC Feb 12, 2025
KaelanDt
KaelanDt reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small docstrings nits otherwise LGTM. Also, for a separate PR but the tolerance parameters in the tests are all quite large (atol = 1, rtol= 1e-1) which may mean some methods don't work as intended, we should perhaps investigate

@SamDuffield
Copy link
Contributor Author

Good point on the test tolerances - have raised issue #120

@SamDuffield SamDuffield requested a review from KaelanDt February 18, 2025 11:39
@SamDuffield SamDuffield merged commit b3ba1ac into main Feb 18, 2025
2 checks passed
@SamDuffield SamDuffield deleted the boaob branch February 18, 2025 11:44
@SamDuffield SamDuffield mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelanDt KaelanDt KaelanDt approved these changes

@gecrooks gecrooks Awaiting requested review from gecrooks

Assignees
No one assigned
Labels
new method New algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @KaelanDt