Skip to content

feat: Add Guardrails System + Code Review Fixes - #54

Open
stegbk wants to merge 22 commits into
devfrom
feature/code-review-fixes-20251010
Open

feat: Add Guardrails System + Code Review Fixes#54
stegbk wants to merge 22 commits into
devfrom
feature/code-review-fixes-20251010

test(coverage): Complete test suite improvements (T010-T012)

8801f0e
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Oct 20, 2025 in 5s

634 new alerts including 2 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 2 high
  • 10 medium

Other Alerts:

  • 10 errors
  • 5 warnings
  • 607 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 114 in backend/api/src/main/python/tests/playwright/specs/chat-conversation-e2e.spec.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable testSessionId.

Check notice on line 209 in backend/api/src/main/python/tests/playwright/specs/chat-conversation-e2e.spec.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable testSessionId.

Check notice on line 112 in backend/api/src/main/python/tests/playwright/specs/ui-features/authentication-e2e.spec.js

See this annotation in the file changed.

Code scanning / CodeQL

Semicolon insertion Note test

Avoid automated semicolon insertion (96% of all statements in
the enclosing function
Loading
have an explicit semicolon).

Check notice on line 187 in backend/api/src/main/python/tests/playwright/specs/ui-features/authentication-e2e.spec.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable errorVisible.

Check notice on line 16 in backend/api/src/main/python/tests/playwright/specs/validate-family-dialog.spec.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable familyId.

Check notice on line 2 in frontend/src/components/AddFamilyModal.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import X.

Check notice on line 2 in frontend/src/components/AddFamilyModalEnhanced.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import Users.

Check notice on line 10 in frontend/src/components/AddFamilyModalEnhanced.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import DialogDescription.

Check notice on line 15 in frontend/src/components/AddFamilyModalEnhanced.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import cn.

Check notice on line 1 in frontend/src/pages/AIProviderSettings.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import useEffect.

Check notice on line 2 in frontend/src/pages/AnimalConfig.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import Eye.

Check notice on line 3 in frontend/src/pages/AnimalDetails.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import X.

Check notice on line 3 in frontend/src/pages/Dashboard.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import BarChart3.

Check notice on line 13 in frontend/src/pages/FamilyManagementBidirectional.tsx

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports canEditFamilies, getFamilyActions.

Check notice on line 2 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Dict' is not used.

Check notice on line 3 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Tuple' is not used.

Check notice on line 4 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Union' is not used.

Check notice on line 6 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Error' is not used.

Check notice on line 7 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'PagedUsers' is not used.

Check notice on line 9 in backend/api/src/main/python/openapi_server/controllers/admin_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'UserDetails' is not used.

Check notice on line 1 in backend/api/src/main/python/openapi_server/controllers/analytics_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'connexion' is not used.

Check notice on line 2 in backend/api/src/main/python/openapi_server/controllers/analytics_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Dict' is not used.

Check notice on line 3 in backend/api/src/main/python/openapi_server/controllers/analytics_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Tuple' is not used.

Check notice on line 4 in backend/api/src/main/python/openapi_server/controllers/analytics_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Union' is not used.

Check notice on line 6 in backend/api/src/main/python/openapi_server/controllers/analytics_controller.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'BillingSummary' is not used.