NIP-66: Define output tags for ssl, geo, and net checks; fix timeout/l-tag/c-tag docs#2200
Draft
VincenzoImp wants to merge 1 commit intonostr-protocol:masterfrom
Draft
NIP-66: Define output tags for ssl, geo, and net checks; fix timeout/l-tag/c-tag docs#2200VincenzoImp wants to merge 1 commit intonostr-protocol:masterfrom
VincenzoImp wants to merge 1 commit intonostr-protocol:masterfrom
Conversation
This PR proposes additions to NIP-66 to standardize the output format for checks that are already declarable in kind 10166 but lack defined result tags in kind 30166. Changes: **Bug Fixes:** - Fix timeout tag format documentation (text contradicted example) - Document l (language) tag that was in example but not documented - Clarify c tag check values (ws → open/read/write) **New Output Tags:** - SSL/TLS: ssl, ssl-expires, ssl-issuer - Network: net-ip, net-ipv6, net-asn, net-asn-org - Geographic: geo-country, geo-city, geo-lat, geo-lon, geo-tz **Documentation:** - Add formal check-to-output mapping table - Reorganize tags by category (Basic, RTT, SSL, Network, Geographic) - Add Use Cases and Privacy Considerations sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2171
See issue for full details.