-
Notifications
You must be signed in to change notification settings - Fork 744
NIP-91: AND operator for filters #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hzrd149
wants to merge
11
commits into
nostr-protocol:master
Choose a base branch
from
dskvr:nip/119
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3086a20
NIP-119
dskvr b049185
remove 'considerations' and 'index efficiency'
dskvr c7da9d7
remove rationale
dskvr b792e36
Update 119.md
dskvr 6280c81
Add 91.md, add Filter table to README
dskvr c5c0750
hotfix: heading NIP-119 -> NIP-91
dskvr 09846e0
fix: heading
dskvr e88308f
Clarify rules for AND and OR tag precedence
dskvr cc87b29
Add 'black' and 'white' to filter tags in 91.md
dskvr fc24f54
Fix wording for AND tag value requirements
dskvr dd9ab39
Update 91.md
dskvr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # NIP-91: AND Operator in Filters | ||
|
|
||
| Enable `AND` within a single tag filter by using an `&` modifier in filters for indexable tags. | ||
|
|
||
| ``` | ||
| filters: { | ||
| "kinds": [1], | ||
| "&t": ["meme", "cat", "black", "white"], | ||
| "#t": ["black", "white"] | ||
| } | ||
| // returns kind `1` events with `t` tags that have both "meme" and "cat" that have the tag "black" or "white" by NIP-91 relays, whereas relays without NIP-91 return entire result for local intersection. | ||
| ``` | ||
|
|
||
| ## Rules | ||
|
|
||
| - `AND` **MUST** take precedence over `OR` by relays | ||
| - Any tag value used in `AND` **SHOULD** be ignored in `OR` by relays supporting NIP-91 | ||
| - Tag values used in `AND` by libraries and clients **MUST** include standard `OR` tags [`#`] for compatibility with relays that do not support NIP-91. | ||
| - libraries and clients `SHOULD` run `&` post-filters after recieving results from relays; already standard practice. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.