Update socket.js to use zeromq instead of zmq#57
Open
drdarshan wants to merge 1 commit intonotablemind:masterfrom
Open
Update socket.js to use zeromq instead of zmq#57drdarshan wants to merge 1 commit intonotablemind:masterfrom
drdarshan wants to merge 1 commit intonotablemind:masterfrom
Conversation
|
Thanks @drdarshan ! Your fork built fine on my machine while the current here failed. Hopefully a maintainer can take a look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #56 that replaces the
zmqpackage withzeromqand removes the compilation of ZeroMQ from source. I believe this will also simplify the Dockerfile although I have not tackled that yet.Feedback appreciated, thanks for the great work!