Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update plugin spec #809

Merged
merged 21 commits into from
Nov 20, 2023
Merged

Conversation

FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Oct 27, 2023

Update notation plugin spec based on #549 and PRD

Added new commands and examples including:

  • notation plugin install Install a plugin
  • notation plugin ninstall Uninstall a plugin

Updated the output of notation plugin list.

Signed-off-by: Feynman Zhou <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31c9e84) 64.09% compared to head (9481477) 64.05%.
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   64.09%   64.05%   -0.05%     
==========================================
  Files          40       40              
  Lines        2284     2323      +39     
==========================================
+ Hits         1464     1488      +24     
- Misses        698      709      +11     
- Partials      122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou . I did a first round review, will take another pass later.

specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
@FeynmanZhou
Copy link
Member Author

@rgnote @priteshbandi @iamsamirzon Would you mind reviewing the notation plugin mgmt spec updates? Thanks

specs/commandline/plugin.md Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Nov 17, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yizha1
yizha1 previously approved these changes Nov 17, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Outdated Show resolved Hide resolved
specs/commandline/plugin.md Show resolved Hide resolved
Signed-off-by: Feynman Zhou <[email protected]>
@FeynmanZhou FeynmanZhou dismissed stale reviews from yizha1 and Two-Hearts via 54d8f85 November 17, 2023 09:48
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 2bfcee6 into notaryproject:main Nov 20, 2023
5 checks passed
priteshbandi pushed a commit that referenced this pull request Dec 5, 2023
This PR is based on the spec PR: #809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Dec 14, 2023
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: rgnote <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: rgnote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants