Skip to content
This repository was archived by the owner on Sep 24, 2021. It is now read-only.

docs: specify that FCM integration methods must be async #2

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

mikehardy
Copy link
Contributor

Causes problems noticed here if not async: invertase/react-native-notifee#14 (comment)

@mikehardy
Copy link
Contributor Author

@Ehesp / @Salakar of interest - notifee problem discovered + solution provided => doc update

Copy link
Contributor

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @mikehardy - I tweaked it slightly 😅

@Salakar Salakar changed the title Specify that FCM integration methods must be async docs: specify that FCM integration methods must be async Jul 7, 2020
@Salakar Salakar merged commit 06b432a into notifee:master Jul 7, 2020
@mikehardy
Copy link
Contributor Author

Yeah - I struggled with it honestly. In the type def for messaging in react-native-firebase repo they are actually not coherent! One of them (onMessage) makes no mention of needing a promise return or being async, but setBackgroundMessageHandler does. Not sure how to fix? The example is clear so perhaps just altering the typedef?

https://github.com/invertase/react-native-firebase/blob/f0959f2054d46578da7769d217cf02f793412a41/packages/messaging/lib/index.d.ts#L621-L647

@mikehardy mikehardy deleted the patch-1 branch July 7, 2020 18:48
@Salakar
Copy link
Contributor

Salakar commented Jul 7, 2020

Have added it to this weeks planner to check out the types, so it should get looked at hopefully by someone 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants