[WIP] Replace Try methods that use out ref to pass the value to std optional#582
Open
RyadaProductions wants to merge 4 commits intonovelrt:mainfrom
Open
[WIP] Replace Try methods that use out ref to pass the value to std optional#582RyadaProductions wants to merge 4 commits intonovelrt:mainfrom
RyadaProductions wants to merge 4 commits intonovelrt:mainfrom
Conversation
Updated documentation
RyadaProductions
requested review from
RubyNova and
tannergooding
as code owners
RyadaProductions
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Code API change to move to a method signature that returns an optional instead of being invoked with a pass by ref parameter that is then set.
Is there an open issue that this resolves?
563.
What is the current behavior?
Method signature is generally something along the lines of:
bool TrySomething(T& outParam);What is the new behavior (if this is a feature change)?
New method signature most of the time is now:
std::optional<T&> TrySomething()Does this PR introduce a breaking change?
Yes this breaks the API in multiple spots but generally not for the end user yet as it's mostly isolated in engine code.