Fix issue where tests fail to find chai library.#1983
Closed
tsukasa-au wants to merge 1 commit into
Closed
Conversation
A breaking change to how the chai library is bundled was made between 5.x.x and 6.x.x (it was originally made in 5.3.1, but that change was reverted in 5.3.2, then made again after bumping the major version number). This results in all locally executed karma tests failing due to a missing file. This is a temporary work around until someone correctly fixes our usage or this libary.
Merged
Member
|
We'd prefer to fix it properly. Do you have a reference to what has changed? |
Contributor
Author
|
I think the original change was done in chaijs/chai#1694 (remove bundled chai), it was rolled back in chaijs/chai#1699, then rolled forward (with a version bump) in chaijs/chai#1700. My knowledge of modern javascript is a little rusty... But chaijs/chai#1698 seems to suggest we should be using |
Contributor
|
This was fixed in commit 8ebd9dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breaking change to how the chai library is bundled was made between 5.x.x and 6.x.x (it was originally made in 5.3.1, but that change was reverted in 5.3.2, then made again after bumping the major version number). This results in all locally executed karma tests failing due to a missing file.
This is a temporary work around until someone correctly fixes our usage or this libary.