Fix silent module load failure in Chrome 86-93 due to missing VideoDecoder.isConfigSupported#2061
Open
YoongiKim wants to merge 1 commit into
Open
Conversation
Chrome 86-93 shipped VideoDecoder as part of an origin trial but did not include the isConfigSupported method (added in Chrome 94). Calling it without checking its existence caused a silent module load failure. Fixes novnc#2060 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2060
Chrome 86–93 shipped
VideoDecoderas part of an origin trial but did not includeVideoDecoder.isConfigSupported— that method was only added in Chrome 94. The existing guard in_checkWebCodecsH264DecodeSupport()checked forVideoDecoderinwindowbut not forisConfigSupportedon the constructor, causing a "is not a function" error at the top-levelawaitcall site. Because this happens during ES module evaluation, the entire module silently fails to load with no console error — just a blank page.Change
This makes the function gracefully return
falseon browsers that haveVideoDecoderbut lackisConfigSupported, instead of throwing.🤖 Generated with Claude Code