fix(dashboard): allow password manager autofill on self-hosted auth forms - #12445
Open
De-pitcher wants to merge 5 commits into
Open
De-pitcher wants to merge 5 commits into
De-pitcher wants to merge 5 commits into
Conversation
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
|
@De-pitcher is attempting to deploy a commit to the Novu Team on Vercel. A member of the Team first needs to authorize it. |
De-pitcher
force-pushed
the
fix/self-hosted-auth-autofill
branch
from
August 25, 2026 14:28
5f9d732 to
95aea31
Compare
De-pitcher
marked this pull request as ready for review
August 25, 2026 17:02
Contributor
Author
|
Thanks for the approval! This PR is ready to merge whenever you are — all checks green, rebased on latest Let me know if there's anything else you'd like to see before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fixes #12267.
Since #7281 moved
AUTOCOMPLETE_PASSWORD_MANAGERS_OFFinto the sharedInputprimitive, every dashboard input — including self-hosted sign-in/sign-up/forgot-password/reset-password fields — renders with anti-autofill markers (autoComplete="off",data-1p-ignore,data-form-type="other"). Browsers and password managers therefore refuse to fill or save credentials on the self-hosted auth forms (Novu Cloud is unaffected because Clerk renders its own form).This PR exempts the auth inputs from that suppression:
AUTOCOMPLETE_PASSWORD_MANAGERS_ONconstant whoseundefinedvalues cancel the suppression attributes when spread after the shared default (InputElapplies caller props last, so the cancellation wins and React omits the removed attributes)name="email"+autoComplete="email"name="password"+autoComplete="current-password"autoComplete="new-password"given-name/family-name; organization →organizationSignIn/SignUp(self-hosted/components.tsx) and the better-authSignIn/SignUp/ForgotPassword/ResetPasswordformsThe workflow-editor and integration-credential use cases that motivated #6975/#7281 keep their suppression behavior unchanged — the base
Inputprimitive is not modified.Special notes for your reviewer
{ ...OFF, ...ON, ...callerProps }resolves todata-1p-ignore: undefined, which React omits from the DOM entirely (passingfalsewould still render"false", which 1Password treats as opted out).apps/dashboardtoday, so verification was done via typecheck (tsc -bclean for all touched files), Biome (no new diagnostics), and a spread-semantics check proving the final prop bag drops the suppression keys.Greptile Summary
Restores browser and password-manager autofill on self-hosted authentication forms without changing the shared Input primitive’s default suppression behavior.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Shared Input defaults] --> B[Password-manager suppression] C[Auth field cancellation props] --> D[Caller props spread last] B --> D E[Field name and autocomplete token] --> D D --> F[Rendered auth input with autofill enabled]Reviews (7): Last reviewed commit: "Merge branch 'next' into fix/self-hosted..." | Re-trigger Greptile