Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: splits out smoke-tests from publish-dryrun tests #8069

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Jan 28, 2025

This removes the publish.sh --smoke-publish like from the current smoke-publish-test.sh (renaming it to smoke-test.sh) and runs both operations as seperete jobs within the ci.yml (on pr) and ci-release.yml (on merge) workflow.

Why? To avoid changed files / git dirty issues from one operation to the next.

With this PR we should have the same checks that merge has, on pr as well, preventing scenarios where a PR breaks a smoke test or publish --smoke-publish test. The only difference between merge / pr is that merge has more tested node versions, if PRs start to pass but fail in these version lets add the full matrix.

npm i npm@latest -g && node scripts/git-dirty.js && node scripts/resetdeps.js && ./scripts/smoke-tests.sh
npm i npm@latest -g && node scripts/git-dirty.js && node scripts/resetdeps.js && node ./scripts/publish.js --pack-destination=${pwd} --smoke-publish=true

@reggi reggi requested a review from a team as a code owner January 28, 2025 17:28
scripts/publish-dryrun.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@reggi reggi requested a review from wraithgar January 29, 2025 14:30
@wraithgar wraithgar merged commit 61f00e3 into latest Jan 29, 2025
26 checks passed
@wraithgar wraithgar deleted the reggi/fix-smokes branch January 29, 2025 16:18
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants