chore: splits out smoke-tests from publish-dryrun tests #8069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
publish.sh --smoke-publish
like from the currentsmoke-publish-test.sh
(renaming it tosmoke-test.sh
) and runs both operations as seperete jobs within theci.yml
(on pr) andci-release.yml
(on merge) workflow.Why? To avoid changed files / git dirty issues from one operation to the next.
With this PR we should have the same checks that merge has, on pr as well, preventing scenarios where a PR breaks a
smoke test
orpublish --smoke-publish
test. The only difference between merge / pr is that merge has more tested node versions, if PRs start to pass but fail in these version lets add the full matrix.