Repository navigation
[nrf toup] Derive BDX download timeout from session round trip - #760
Conversation
|
none Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
|
|
| constexpr System::Clock::Timeout kExpectedProviderProcessingTime = System::Clock::Seconds16(2); | ||
|
|
||
| // Number of round trips without any BDX progress that is treated as a stalled download. | ||
| constexpr uint32_t kDownloadTimeoutRoundTrips = 2; |
There was a problem hiding this comment.
I'm not sure whether this value is not too aggressive. As far as I understand how does it work, we may have a very small round trip time for the device with small communication interval (SED with 1 s sleep, or FTD without sleeping). 2 * roundtrip can be still a very small value, so even short hiccup on the OTA provider side could lead to timeout. Would it make sense to have some lower value to not timeout too often? Some value that we can consider as temporary lag in communication, e.g 7-10 s or something.
There was a problem hiding this comment.
Agreed, I added 10s lower bound for download timeout.
2353f02 to
66e3b29
Compare
The OTA requestor used a fixed five-minute BDX download timeout, which is far too long for sessions with short retransmission intervals and does not adapt to the peer's advertised session parameters. Compute the timeout from the session round trip time plus the expected provider processing time. Signed-off-by: Dominik Michalczyk <dominik.michalczyk@nordicsemi.no>
66e3b29 to
92daf85
Compare
From PR: nrfconnect/sdk-connectedhomeip#760 Signed-off-by: Dominik Michalczyk <dominik.michalczyk@nordicsemi.no>
From PR: nrfconnect/sdk-connectedhomeip#760 Signed-off-by: Dominik Michalczyk <dominik.michalczyk@nordicsemi.no>
Summary
The OTA requestor used a fixed five-minute BDX download timeout, which is far too long for sessions with short retransmission intervals and does not adapt to the peer's advertised session parameters. Compute the timeout from the session round trip time plus the expected provider processing time.
Testing
ncs-matter
manifest-pr-skip