Repository navigation
Implement NFC commisisoning unpowered mode - #763
ArekBalysNordic wants to merge 2 commits into
Conversation
2c11ba2 to
a071481
Compare
| } | ||
| } | ||
|
|
||
| void CommissioningWindowManager::OnNfcBasedCommissioningStarting() |
There was a problem hiding this comment.
Shouldn't this code be under CHIP_NFC_BASED_COMMISSIONING ifdef?
|
|
||
| /** | ||
| * Signals to connect the device to the operational network using credentials | ||
| * received from unpowered NFC commissioning data. |
There was a problem hiding this comment.
Is NFC the only use case for that signal? If yes, shouldn't handling be guarded by ifdef (and named in less generic way)?
| debugText = MutableCharSpan(debugTextBuffer); | ||
| #endif | ||
| uint8_t outNetworkIndex = 0; | ||
| NetworkCommissioningStatusEnum networkingStatus = this_->mpDriver.Get<ThreadDriver *>()->AddOrUpdateNetwork( |
There was a problem hiding this comment.
I think it would need some ifdef as well, because calling ThreadDriver directly will not compile for Wi-Fi or Ethernet.
| ISO-DEP (Type 4A) session. | ||
|
|
||
| config CHIP_NFC_COMMISSIONING_MODE_UNPOWERED | ||
| bool "Unpowered (external ST25DA-C via I2C)" |
There was a problem hiding this comment.
I would not mention ST and I2C here. Let's keep it generic - companion/external NFC tag
| prompt "NFC commissioning mode" | ||
| default CHIP_NFC_COMMISSIONING_MODE_POWERED | ||
|
|
||
| config CHIP_NFC_COMMISSIONING_MODE_POWERED |
There was a problem hiding this comment.
This is more like a question than request. I'm a bit concerned about our naming. It follows the requests that we got, but in fact when choosing "unpowered" mode it could be that we will handle it in "powered" way, right? It's more like "powered" means "powered only" and "unpowered" means "unpowered or powered". Also I'm not sure that it explains well why different handling in software is needed.
I was thinking about "on-chip" and "external chip" but it is true for our SoC, some other vendors may support unpowered mode with their MCU. Maybe this would be better to name it like single step or two step mode? I don't know...
- Added required functions to allow performing NFC commissioning - Added an event to handle connecting to operational network - Added Opening commissioning window for NFC purposes - Updated NetworkCommissioningCluster to use the new event
a071481 to
45fa581
Compare
- Added define switch for powered and unpowered NFC Commissioning modes - Added Kconfigs to switch between these two modes. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
45fa581 to
8368793
Compare
Summary
Testing
ncs-matter
manifest-pr-skip