Repository navigation
[nrf toup][nrfconnect] Handle DAC key in ITS when KMU migration is se… - #767
Open
ArekBalysNordic wants to merge 1 commit into
Open
ArekBalysNordic wants to merge 1 commit into
ArekBalysNordic wants to merge 1 commit into
Conversation
…lected Detect when the DAC private key remains in PSA ITS while factory data is configured to migrate the key to CRACEN KMU. Abort boot in that case unless CHIP_CRYPTO_PSA_DAC_PRIV_KEY_KMU_ITS_FALLBACK is enabled; then sign attestations with the ITS key and log a warning because ITS-to-KMU migration is not supported. Extend KMU-related Kconfig dependencies to CRACEN_LIB_KMU. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
fix_dac_its_org
branch
from
October 23, 2026 08:53
b73813e to
38b3070
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Factory reset can permanently erase the only attestation private key on non-TF-M devices using ITS fallback.
1 open issue
What changed in this PR
This PR updates nRF Connect device-attestation key handling when KMU storage is configured but an existing key remains in PSA ITS.
Changes:
- Adds configurable ITS fallback, enabled by default, with a warning; disabling fallback makes detection fatal.
- Routes attestation signing through the retained ITS key when fallback is active.
- Allows KMU configuration with either
CRACEN_KMUorCRACEN_LIB_KMU.
| File | Description |
|---|---|
src/platform/nrfconnect/FactoryDataProvider.h |
Declares fallback detection and state. |
src/platform/nrfconnect/FactoryDataProvider.cpp |
Detects ITS keys and adjusts migration and signing behavior. |
config/nrfconnect/chip-module/Kconfig |
Adds the fallback option and broadens KMU availability. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CONFIG_CHIP_CRYPTO_PSA_DAC_PRIV_KEY_FATAL_IF_IN_ITS to detect
a DAC private key still stored in PSA ITS when factory data is
configured for CRACEN KMU.
Testing
ncs-matter