Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Sep 25, 2025

test_sdk_dfu: PR-586

@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 25, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 25, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@be1a9fd nrfconnect/sdk-zephyr@077c913 nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from 4beedbb to 1ae7694 Compare September 25, 2025 14:35
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 25, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 42

Inputs:

Sources:

sdk-nrf: PR head: c1f985c52c6364a38f00e0d2c1ee800acff65889
zephyr: PR head: 077c91359e7b5b7d9ab18e8ad413d74432d4ffa9

more details

sdk-nrf:

PR head: c1f985c52c6364a38f00e0d2c1ee800acff65889
merge base: e9d6ae8d2687a639b6434cd17ec1efd945304f24
target head (main): 3ac4add3d8a704fe4d423377bdaff1d350c4782b
Diff

zephyr:

PR head: 077c91359e7b5b7d9ab18e8ad413d74432d4ffa9
merge base: be1a9fd0eecaec02c882b52d2a9b411a1c6cb70c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (53)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  ├── app_common.dtsi
│  │  │  │  ├── images
│  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │ app.overlay
│  │  │  │  ├── memory_map.dtsi
│  │  │  │  ├── sysbuild.conf
│  │  │  │  ├── sysbuild_dongle.conf
│  │  │  │  ├── sysbuild_release.conf
│  │  │  │  │ sysbuild_release_dongle.conf
│  │  │  ├── nrf54h20dk_nrf54h20_cpurad
│  │  │  │  ├── images
│  │  │  │  │  ├── ipc_radio
│  │  │  │  │  │  │ app.overlay
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ dfu.c
cmake
│  ├── sysbuild
│  │  ├── mcuboot_nrf54h20.cmake
│  │  │ sign_nrf54h20.cmake
samples
│  ├── dfu
│  │  ├── ab
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  ├── src
│  │  │  │  │ ab_utils.c
│  │  │  ├── sysbuild.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── ipc_radio.overlay
│  │  │  │  │ nrf54h20dk_nrf54h20_memory_map.dtsi
│  ├── zephyr
│  │  ├── smp_svr_mini_boot
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_direct_xip.overlay
│  │  │  ├── sample.yaml
│  │  │  ├── sysbuild
│  │  │  │  ├── ipc_radio_direct_xip.overlay
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_direct_xip.overlay
│  │  │  │  ├── nrf54h20dk_nrf54h20_memory_map_direct_xip.dtsi
│  │  │  │  │ nrf54h20dk_nrf54h20_memory_map_merged_slot.dtsi
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── smp_svr
│  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp_merged_slot.overlay
│  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_requests.overlay
│  │  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  │  ├── ipc_radio_merged_slot.overlay
│  │  │  │  │  │  │  ├── ipc_radio_requests.overlay
│  │  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_memory_map_merged_slot.dtsi
│  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_memory_map_requests.dtsi
│  │  │  │  │  │  ├── sysbuild_merged_slot.conf
│  │  │  │  │  │  │ sysbuild_requests.conf
scripts
│  │ quarantine_zephyr.yaml
subsys
│  ├── bootloader
│  │  │ Kconfig
sysbuild
│  │ CMakeLists.txt
tests
│  ├── subsys
│  │  ├── bootloader
│  │  │  ├── upgrade
│  │  │  │  ├── ref_smp_svr
│  │  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_direct_xip.overlay
│  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  ├── ipc_radio_direct_xip.overlay
│  │  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_direct_xip.overlay
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_memory_map_direct_xip.dtsi
│  │  │  │  │  │ testcase.yaml
west.yml
zephyr
│  ├── arch
│  │  ├── common
│  │  │  │ CMakeLists.txt
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  │ Kconfig.defconfig
│  ├── cmake
│  │  ├── linker
│  │  │  ├── arcmwdt
│  │  │  │  │ linker_flags.cmake
│  │  │  ├── armlink
│  │  │  │  │ linker_flags.cmake
│  │  │  ├── iar
│  │  │  │  │ linker_flags.cmake
│  │  │  ├── ld
│  │  │  │  │ linker_flags.cmake
│  │  │  ├── xt-ld
│  │  │  │  │ linker_flags.cmake
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54h
│  │  │  │  │ soc.c
│  ├── subsys
│  │  ├── dfu
│  │  │  ├── img_util
│  │  │  │  │ flash_img.c
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── grp
│  │  │  │  │  ├── img_mgmt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ img_mgmt.c
│  ├── tests
│  │  ├── subsys
│  │  │  ├── dfu
│  │  │  │  ├── img_util
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-sdk-audio
    • ◻️ desktop52_verification
    • ◻️ test-fw-nrfconnect-apps
    • ◻️ test_ble_nrf_config
    • ◻️ test-fw-nrfconnect-ble_mesh
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ◻️ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ◻️ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ◻️ test-fw-nrfconnect-nrf-iot_samples
    • ◻️ test-fw-nrfconnect-nrf-iot_lwm2m
    • ◻️ test-fw-nrfconnect-nrf-iot_thingy91
    • ◻️ test-fw-nrfconnect-nrf_crypto
    • ◻️ test-fw-nrfconnect-proprietary_esb
    • ◻️ test-fw-nrfconnect-rpc
    • ◻️ test-fw-nrfconnect-rs
    • ◻️ test-fw-nrfconnect-fem
    • ◻️ test-fw-nrfconnect-tfm
    • ◻️ test-fw-nrfconnect-thread-main
    • ◻️ test-sdk-find-my
    • ◻️ test-sdk-wifi
    • ◻️ test-low-level
    • ◻️ test-sdk-pmic-samples
    • ◻️ test-sdk-mcuboot
    • ◻️ test-sdk-dfu
    • ◻️ test-fw-nrfconnect-ps-main
    • ◻️ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Note: This message is automatically posted and updated by the CI

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from 1ae7694 to d106054 Compare September 25, 2025 15:14
@github-actions
Copy link

You can find the documentation preview for this PR here.

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch 2 times, most recently from 20f72d8 to 55dd942 Compare September 26, 2025 09:43
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 26, 2025

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9102[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5858[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9492[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24707/40)

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch 3 times, most recently from c95e856 to 6250267 Compare October 2, 2025 15:26
@tomchy tomchy marked this pull request as ready for review October 2, 2025 15:30
@tomchy tomchy requested a review from a team as a code owner October 2, 2025 15:30
@tomchy tomchy requested review from a team October 2, 2025 15:30
@tomchy tomchy requested review from a team as code owners October 2, 2025 15:30
Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the nRF Desktop part

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from 6250267 to ee7d662 Compare October 9, 2025 07:33
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from ee7d662 to 143fa24 Compare October 10, 2025 07:25
Copy link
Contributor

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from 143fa24 to 215b616 Compare October 10, 2025 13:41
@NordicBuilder NordicBuilder requested review from a team October 17, 2025 14:31
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch 3 times, most recently from 8c209da to f1a9459 Compare October 17, 2025 15:11
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from f1a9459 to 6d83626 Compare October 20, 2025 07:21
@NordicBuilder NordicBuilder requested review from a team October 20, 2025 07:22
@tomchy tomchy requested a review from gchwier October 20, 2025 07:22
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch 2 times, most recently from 1ac2239 to 330bf9e Compare October 20, 2025 14:55
It is possible to add MCUboot header through --pad-header option.
In such cases, the FLASH_LOAD_OFFSET does not point to the begining of
the slot, but to the beginning of the executable area, thus the check
for the active slot should use ranges instead of exact values.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add routine that checks if all merged images are configured within the
boundary of the merged partition.

Ref: NCSDK-35612

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from 330bf9e to df0db7c Compare October 20, 2025 17:46
Adjust logic, so the merged slots do not include gaps between images.

Ref: NCSDK-25612

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Allow to start the FW code in the middle of the MCUboot slot.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Quarantine kernel.common.misra on nRF54L15dk.
Issue alreade reported in: NCSDK-35491

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Align the ref_smp_svr sample with the optimized merged slots.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the bugfix/mcuboot/NCSDK-35612_Fix_merged_slot_offsets branch from df0db7c to c1f985c Compare October 21, 2025 07:03
@NordicBuilder NordicBuilder requested review from a team October 21, 2025 07:04
@NordicBuilder NordicBuilder removed the DNM label Oct 21, 2025
@tomchy tomchy merged commit 2893808 into nrfconnect:main Oct 21, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-mcuboot manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants