Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Sep 30, 2025

No description provided.

@tomchy tomchy requested review from a team as code owners September 30, 2025 13:15
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 30, 2025
@tomchy tomchy changed the title Add common function to read partition address from CMake Add a common function to read partition address from CMake Sep 30, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 30, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 30, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 18

Inputs:

Sources:

sdk-nrf: PR head: 1e0b7128b8900a26ad59de3d475fbe67a13d015e

more details

sdk-nrf:

PR head: 1e0b7128b8900a26ad59de3d475fbe67a13d015e
merge base: 4b2a6dbe1cf0f862f932568bf6e935b213ca2b72
target head (main): d4cc83e58e25e71ac502b6dc92ca10a878691079
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
cmake
│  ├── modules
│  │  │ kconfig.cmake
│  ├── sysbuild
│  │  ├── bootloader_dts_utils.cmake
│  │  ├── image_signing.cmake
│  │  │ sign_nrf54h20.cmake

Outputs:

Toolchain

Version: f66cf421f3
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f66cf421f3_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 17
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

You can find the documentation preview for this PR here.

@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 859c70b to 0474ea0 Compare September 30, 2025 14:14
@tomchy tomchy requested review from a team September 30, 2025 14:14
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 0474ea0 to a913cc8 Compare September 30, 2025 14:44
@tomchy
Copy link
Contributor Author

tomchy commented Sep 30, 2025

Scope reduced: There is no point in adding multiple overrides if they are about to be removed once the support for subpartitions will be introduced..

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 30, 2025

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9492[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9102[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5858[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24792/17)

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round revierw.
Please note that line length limit is 100 chars, so some lines is not required to wrap.
I've only pointed out a few.

@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from a913cc8 to 98e4353 Compare October 2, 2025 12:50
@tomchy tomchy requested a review from tejlmand October 2, 2025 12:50
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.

Mostly minor nits, and some observations.

Please checkup regarding line length and line wrapping.
Take a look at the CMake Style Guidelines

@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch 2 times, most recently from c804096 to 5419a9b Compare October 2, 2025 13:41
@tomchy tomchy requested a review from tejlmand October 2, 2025 13:41
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 5419a9b to 4fd1e90 Compare October 3, 2025 08:53
Copy link
Contributor

@ahasztag ahasztag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion regarding a variable name

@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 4fd1e90 to f7d7e2a Compare October 3, 2025 14:25
@tomchy tomchy requested a review from ahasztag October 3, 2025 14:25
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from f7d7e2a to 07dc5a3 Compare October 6, 2025 09:19
@NordicBuilder NordicBuilder removed the DNM label Oct 6, 2025
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 07dc5a3 to 0861989 Compare October 8, 2025 11:45
@tomchy tomchy requested a review from tejlmand October 8, 2025 11:45
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch 4 times, most recently from c27a4ae to 698971e Compare October 9, 2025 11:04
Add a common bootloader_dts_util to read both the relative and absolute
address of a fixed sub/partition from DTS.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the feature/cmake/NCSDK-NONE_Unify_partition_addresses branch from 698971e to 1e0b712 Compare October 9, 2025 14:33
@tomchy tomchy merged commit 18f0fd6 into nrfconnect:main Oct 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants