-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add a common function to read partition address from CMake #24792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a common function to read partition address from CMake #24792
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1e0b7128b8900a26ad59de3d475fbe67a13d015e more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: f66cf421f3 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
859c70b to
0474ea0
Compare
0474ea0 to
a913cc8
Compare
|
Scope reduced: There is no point in adding multiple overrides if they are about to be removed once the support for subpartitions will be introduced.. |
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24792/17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round revierw.
Please note that line length limit is 100 chars, so some lines is not required to wrap.
I've only pointed out a few.
a913cc8 to
98e4353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better.
Mostly minor nits, and some observations.
Please checkup regarding line length and line wrapping.
Take a look at the CMake Style Guidelines
c804096 to
5419a9b
Compare
5419a9b to
4fd1e90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion regarding a variable name
4fd1e90 to
f7d7e2a
Compare
f7d7e2a to
07dc5a3
Compare
07dc5a3 to
0861989
Compare
c27a4ae to
698971e
Compare
Add a common bootloader_dts_util to read both the relative and absolute address of a fixed sub/partition from DTS. Signed-off-by: Tomasz Chyrowicz <[email protected]>
698971e to
1e0b712
Compare
No description provided.