-
Notifications
You must be signed in to change notification settings - Fork 1.4k
mgmt: Handle bootloader requests #25255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt: Handle bootloader requests #25255
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: f305f877e9097dfb870e9dc9058527e6c5e6b06e more detailssdk-nrf:
Github labels
List of changed files detected by CI (9)Outputs:ToolchainVersion: cfa6b06338 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
9b5adff to
6638616
Compare
6638616 to
776e0b6
Compare
776e0b6 to
54ff202
Compare
54ff202 to
90927ea
Compare
1a28bdd to
bee1a89
Compare
|
Accidentally cherry-picked changes from #25307. Reverted to include only the change in Kconfig and west.yml. |
bee1a89 to
eb83310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the sdk-zephyr and sdk-mcuboot dependencies to pull request branches for testing/review purposes, and adds a new Kconfig option for boot preference testing in MCUboot.
- Updates sdk-zephyr revision from a commit SHA to
pull/3429/head - Updates sdk-mcuboot revision from a commit SHA to
pull/563/head - Adds
NCS_MCUBOOT_BOOT_REQUEST_TEST_SETS_BOOT_PREFERENCEKconfig option for testing boot preference with image test marking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| west.yml | Updates sdk-zephyr and sdk-mcuboot dependency revisions to pull request branches |
| modules/mcuboot/Kconfig | Adds new Kconfig option for boot preference testing functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eb83310 to
61221fe
Compare
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs change in scripts/ci/license_allow_list.yaml
|
also the commit adding the file needs to specify the zephyr commit ID the revision came from - note zephyr not sdk-zephyr |
Looking at the current stage - the auto-PR will get merged sooner than this PR. This may give me a quicker turnarounds (less time waiting for the CI) if the new process of modifying zephyr files brings more comments from the reviewers. |
61221fe to
fcf3dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fcf3dc6 to
d3b7941
Compare
d3b7941 to
2e53220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move NCS_MCUBOOT_BOOT_REQUEST_TEST_SETS_BOOT_PREFERENCE since it is an application Kconfig, not a bootloader one. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a copy of the img_mgmt_state.c file, so it can be adjusted to work with all NCS-specific extensions. Zephyr revision: 25269118b5069ebb72316d2a26bdedbe6ba8de95 Signed-off-by: Tomasz Chyrowicz <[email protected]>
Interpret pending active slot requests while calculating the expected next slot to boot. Signed-off-by: Tomasz Chyrowicz <[email protected]>
2e53220 to
f305f87
Compare
Update sdk-zephyr and sdk-mcuboot revisions.
Ref: NCSDK-35821