-
Notifications
You must be signed in to change notification settings - Fork 1.4k
mpsl: Add KConfig around forcing RRAM when running from NONSECURE #25349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpsl: Add KConfig around forcing RRAM when running from NONSECURE #25349
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 5de186623ca56e3ef2585e2926f49534ad6fe6ea more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
b5b015e to
04c0040
Compare
| default y | ||
| help | ||
| This option forces RRAM to stay on. | ||
| This is not needed when only basic bluetooth features are used. | ||
| Only needed when for example LLPM, Frame space update, ISO or Channel Sounding is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not default y when those feature Kconfigs are enabled? instead of just always on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now TRUSTED_EXECUTION_NONSECURE is only experimentally supported.
what I want to achive with this KConfig is that I can tell customers who complain that powerconsumption is too high, that they can set this config to =n as long as they know they are not using any of those features. I didnt find nice kconfigs for all those features to use for those features, because some of them get set automaticaly as long as the HW supports them. So then I would have to tell customers how to disable those configs.
Right now I think just doing it this way is the easiest. but when we move TFM support out of experimental, I think we should improve this yes, either by having it as kconfig like this which defaults depending on the features. But we might also do it even fancier, at runtime and only force RRAM on, on links when any of these features are enabled.
Bottom line, I want to merge this now so I can tell customer in NCS 3.2 that uses NS, that they can enable this if they want low power when using bluetooth as long as they dont use any of these features.
Since this isn't makes powerconsumption be very high, we can let it only be done when "advanced" bluetotoh features are used. Signed-off-by: Martin Tverdal <[email protected]>
04c0040 to
5de1866
Compare
Since this isn't makes powerconsumption be very high, we can let it only be done when "advanced" bluetotoh features are used.