Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): fix behaviour when only 1 generator is available & refactor old code #2242

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Aug 27, 2024

  • lets user select generator when there is only one generator instead of automatically selecting it (this won't affect the move/remove actions)
  • fixes generatorName data that is used in generate ui header
  • show proper error when no move / remove generators are available
  • simplifies & refactors old code (parts of this were still left over from when there was still a task & generate ui)

Copy link

nx-cloud bot commented Aug 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c6ee5af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxKless MaxKless merged commit df7922e into master Sep 20, 2024
5 checks passed
@MaxKless MaxKless deleted the fix-generate-with-1-generator branch September 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants