Skip to content

Commit

Permalink
fix(core): do not check cache validity when putting into the cache (#…
Browse files Browse the repository at this point in the history
…28004)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Invalid cache message shown twice.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Invalid cache message shown once.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
FrozenPandaz authored Sep 19, 2024
1 parent f767bab commit 999abe9
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions packages/nx/src/tasks-runner/cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { readNxJson } from '../config/nx-json';
import { verifyOrUpdateNxCloudClient } from '../nx-cloud/update-manager';
import { getCloudOptions } from '../nx-cloud/utilities/get-cloud-options';
import { isCI } from '../utils/is-ci';
import { output } from '../utils/output';

export type CachedResult = {
terminalOutput: string;
Expand Down Expand Up @@ -97,7 +98,6 @@ export class DbCache {
outputs: string[],
code: number
) {
await this.assertCacheIsValid();
return tryAndRetry(async () => {
this.cache.put(task.hash, terminalOutput, outputs, code);

Expand Down Expand Up @@ -191,13 +191,16 @@ export class DbCache {
// custom directory, and check if the entries are there when the main db
// cache misses.
if (isCI() && !this.cache.checkCacheFsInSync()) {
const warning = [
const warningLines = [
`Nx found unrecognized artifacts in the cache directory and will not be able to use them.`,
`Nx can only restore artifacts it has metadata about.`,
`Read about this warning and how to address it here: https://nx.dev/troubleshooting/unknown-local-cache`,
``,
].join('\n');
console.warn(warning);
];
output.warn({
title: 'Unrecognized Cache Artifacts',
bodyLines: warningLines,
});
}
}
}
Expand Down

0 comments on commit 999abe9

Please sign in to comment.