-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module-federation): add initial module-federation package #28783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
jaysoo,
AgentEnder,
a team,
vsavkin and
JamesHenry
as code owners
November 4, 2024 13:28
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 27aaa28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
reviewed
Nov 4, 2024
jaysoo
approved these changes
Nov 6, 2024
FrozenPandaz
added
the
PR status: do not merge
This will block a PR from being merged until this tag is removed.
label
Nov 6, 2024
Coly010
removed
the
PR status: do not merge
This will block a PR from being merged until this tag is removed.
label
Nov 12, 2024
FrozenPandaz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We do not currently have an
@nx/module-federation
package to house the shared executors and utils for Module Federation acrossWebpack
,Rspack
andAngular
.Expected Behavior
Create a single package to store the Module Federation capabilities within Nx
Related Issue(s)
Fixes #