Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): update ts migration recipe #29815

Merged
merged 3 commits into from
Jan 31, 2025
Merged

docs(core): update ts migration recipe #29815

merged 3 commits into from
Jan 31, 2025

Conversation

isaacplmann
Copy link
Collaborator

Updates migration to TS project references recipe

@isaacplmann isaacplmann requested a review from a team as a code owner January 30, 2025 19:41
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 31, 2025 5:26pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4835245.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 12s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 17:26:05 UTC

@isaacplmann isaacplmann mentioned this pull request Jan 30, 2025
Closed
4 tasks
@isaacplmann
Copy link
Collaborator Author

@electrocnic thanks for reviewing. I updated the guide to address your comments. Let me know if there is anything else that should be clarified.

@isaacplmann isaacplmann merged commit ed1dd5f into master Jan 31, 2025
12 checks passed
@isaacplmann isaacplmann deleted the docs/update-ts-migration-recipe branch January 31, 2025 20:18
bcabanes pushed a commit that referenced this pull request Feb 3, 2025
@isaacplmann @bcabanes
docs(core): update ts migration recipe (#29815)
8f80a57 
Updates migration to TS project references recipe
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@electrocnic electrocnic electrocnic requested changes

@jaysoo jaysoo jaysoo approved these changes

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacplmann @jaysoo @electrocnic