Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow postTaskExecution hook without preTaskExecution hook #29820

Merged

Conversation

HaasStefan
Copy link
Contributor

Current Behavior

postTaskExecution hook is only called if preTaskExecution hook is exported in the plugin.

Expected Behavior

postTaskExecution hook should be independent from preTaskExecution hook. I.e., if preTaskExecution hook is not exported, postTaskExecution hook should still be called after a task execution.

Related Issue(s)

Fixes #

Fixed postTaskExecution hook

@HaasStefan HaasStefan requested a review from a team as a code owner January 30, 2025 23:16
@HaasStefan HaasStefan requested a review from Cammisuli January 30, 2025 23:16
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 31, 2025 4:33pm

Copy link

nx-cloud bot commented Jan 30, 2025

View your CI Pipeline Execution ↗ for commit 5c031d6.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 1h 47m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 7m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 18:23:03 UTC

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit cdd4958 into nrwl:master Jan 31, 2025
11 of 12 checks passed
Copy link

github-actions bot commented Feb 6, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants