[#1090] Fix ACA Provisioning Issue When Using ECC Key

.ci/system-tests/sys_test_common.sh

@@ -13,11 +13,11 @@ tpm2_container=hirs-provisioner1-tpm2
 checkContainerStatus() {
   container_name=$1
   container_id="$(docker ps -aqf "name=$container_name")"
-  container_status="$(docker inspect $container_id --format='{{.State.Status}}')"
+  container_status="$(docker inspect "$container_id" --format='{{.State.Status}}')"
   echo "Container id is $container_id and the status is $container_status"
 
   if [ "$container_status" != "running" ]; then
-     container_exit_code="$(docker inspect $container_id --format='{{.State.ExitCode}}')"
+     container_exit_code="$(docker inspect "$container_id" --format='{{.State.ExitCode}}')"
      echo "Container Exit Code: $container_exit_code"
      docker info
      exit 1;
@@ -146,6 +146,6 @@ setAppsettings() {
 # write_to_logs <log statement>
 writeToLogs() {
   line=$1
-  echo $line;
+  echo "$line";
   docker exec -i $aca_container /bin/bash -c "cd .. && echo '$line' >> /var/log/hirs/HIRS_AttestationCA_Portal.log"
 }

HIRS_AttestationCA/config/spotbugs/spotbugs-exclude.xml

@@ -15,9 +15,5 @@
     <Match>
         <Bug pattern="EI_EXPOSE_REP2"/>
     </Match>
-    <Match>
-        <Class name="hirs.attestationca.persist.AttestationCertificateAuthorityTest"/>
-        <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
-    </Match>
 </FindBugsFilter>
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/manager/SupplyChainValidationSummaryRepository.java

@@ -11,8 +11,7 @@
 import java.util.UUID;
 
 @Repository
-public interface SupplyChainValidationSummaryRepository
-        extends JpaRepository<SupplyChainValidationSummary, UUID> {
+public interface SupplyChainValidationSummaryRepository extends JpaRepository<SupplyChainValidationSummary, UUID> {
 
     /**
      * Query that retrieves a supply chain validation summary using the provided device.

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/enums/PublicKeyAlgorithm.java

@@ -0,0 +1,65 @@
+package hirs.attestationca.persist.enums;
+
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.ToString;
+
+/**
+ * Enum representing public key algorithms for asymmetric cryptography.
+ * <p>
+ * This enum currently includes:
+ * <ul>
+ *   <li>{@link #RSA} – RSA public-key algorithm.</li>
+ *   <li>{@link #ECC} – Elliptic Curve (EC) public-key algorithm, commonly referred to as ECC.</li>
+ * </ul>
+ * <p>
+ * Each enum constant holds the public key algorithm name and id. The ID is listed on the
+ * <a href="https://trustedcomputinggroup.org/wp-content/uploads/TCG-Algorithm-Registry-Version-2.0_pub.pdf">
+ *   TCG Algorithm Registry Version PDF.</a>
+ */
+@Getter
+@AllArgsConstructor
+@ToString
+public enum PublicKeyAlgorithm {
+    /**
+     * RSA Public Key Algorithm.
+     */
+    RSA(0x0001, "RSA"),
+
+    /**
+     * ECC Public Key Algorithm.
+     */
+    ECC(0x0023, "ECC"),
+
+    /**
+     * Represents an unknown public key algorithm.
+     * This is used when the application encounters a public key algorithm that is not recognized or supported.
+     */
+    UNKNOWN(0xFFFF, "UNKNOWN");
+
+    /**
+     * The hexadecimal representation of the algorithm ID as represented in the TCG documents.
+     */
+    private final int algorithmId;
+
+    /**
+     * The name of the algorithm.
+     */
+    private final String algorithmName;
+
+    /**
+     * Retrieves the enum by the algorithm ID.
+     *
+     * @param algorithmId algorithm ID
+     * @return ENUM representation of the public key algorithm
+     */
+    public static PublicKeyAlgorithm fromId(final int algorithmId) {
+        for (PublicKeyAlgorithm algo : values()) {
+            if (algo.getAlgorithmId() == algorithmId) {
+                return algo;
+            }
+        }
+        return UNKNOWN; // If no match found, return UNKNOWN
+    }
+}
+

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/exceptions/CertificateProcessingException.java

@@ -1,7 +1,7 @@
 package hirs.attestationca.persist.exceptions;
 
 /**
- * Generic exception thrown while a {@link hirs.attestationca.persist.AttestationCertificateAuthority}
+ * Generic exception thrown when the the Attestation Certificate Authority Service
  * is processing a newly created Attestation Certificate for a validated identity.
  */
 public class CertificateProcessingException extends RuntimeException {