Skip to content

[#1139] Handle Event Log Cert Issue#1146

Open
iadgovuser58 wants to merge 11 commits intomainfrom
v3.1_issue_1139-handle-eventlog-cert-issue
Open

[#1139] Handle Event Log Cert Issue#1146
iadgovuser58 wants to merge 11 commits intomainfrom
v3.1_issue_1139-handle-eventlog-cert-issue

Conversation

@iadgovuser58
Copy link
Collaborator

@iadgovuser58 iadgovuser58 commented Mar 18, 2026

Description

When an EventLog of type EV_EFI_VARIABLE_DRIVER_CONFIG, UEFI_VARIABLE_DATA name "PK" contains a cert that isn't able to be processed, need to store that error (for print in eventlog tool, and for ACA display in ACA) but not stop validation from continuing.


Test Instructions:

  1. Run the ACA.
  2. Upload support RIM which contains this particular event with a cert that isn't parsable.
  3. Verify that the display still shows this event along with an error stating the non-parsable cert.
  4. Run eventlogtool and verify the print still shows this event along with an error stating the non-parsable cert.

Summary Of Changes:

  1. In the UefiX509Cert class, catch the error, add the error message, and rethrow.
  2. In the calling class, UefiSignatureData, catch the error and 1) store it in the toString, 2) log it in the ACA log as a warning. Then continue.
  3. Cleaned up some repeated code, and incorrect cert buffer size, and comments that had gotten misaligned.

Issues This PR Addresses:

Closes #1139

@iadgovuser58 iadgovuser58 added the bug Something isn't working label Mar 18, 2026
@ThatSilentCoder ThatSilentCoder changed the title V3.1 issue 1139 handle eventlog cert issue [#1139] Handle Event Log Cert Issue Mar 18, 2026
@ThatSilentCoder ThatSilentCoder added the v3.2.0 Issues for Release 3.2.0 of the ACA label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v3.2.0 Issues for Release 3.2.0 of the ACA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catch errors in cert parsing during event log processing and pass up to the ACA

2 participants