Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Serving GA for 1.5 #2422

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Serving GA for 1.5 #2422

wants to merge 2 commits into from

Conversation

vigith
Copy link
Member

@vigith vigith commented Feb 23, 2025

Explain what this PR does.

vigith and others added 2 commits February 22, 2025 20:52
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Co-authored-by: Sidhant Kohli <[email protected]>
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 25.71429% with 52 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (1dc2b31) to head (af96758).

Files with missing lines Patch % Lines
pkg/apis/numaflow/v1alpha1/serving_store.go 0.00% 33 Missing ⚠️
pkg/apis/numaflow/v1alpha1/vertex_types.go 46.66% 6 Missing and 2 partials ⚠️
pkg/apis/numaflow/v1alpha1/sink.go 0.00% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/source.go 0.00% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/udf.go 66.66% 2 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/pipeline_types.go 83.33% 1 Missing ⚠️
pkg/apis/numaflow/v1alpha1/serving_source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   71.16%   70.97%   -0.19%     
==========================================
  Files         368      369       +1     
  Lines       53575    53643      +68     
==========================================
- Hits        38124    38073      -51     
- Misses      14369    14486     +117     
- Partials     1082     1084       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants