chore: ignore mvtx replicas if it exists #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
juliev0
reviewed
Oct 24, 2024
| spec: | ||
| monoVertex: | ||
| spec: | ||
| source: | ||
| udsource: | ||
| container: | ||
| image: quay.io/numaio/numaflow-java/source-simple-source:stable | ||
| env: | ||
| - name: aaaa | ||
| value: bb |
There was a problem hiding this comment.
did you mean to commit this?
juliev0
reviewed
Oct 24, 2024
| @@ -2,19 +2,21 @@ apiVersion: numaplane.numaproj.io/v1alpha1 | |||
| kind: MonoVertexRollout | |||
| metadata: | |||
| name: my-monovertex | |||
There was a problem hiding this comment.
did you mean to remove namespace? if you did, can you remove it from all 4 example Rollouts?
There was a problem hiding this comment.
Those were for my testing, accidentally committed, will remove.
juliev0
reviewed
Oct 24, 2024
| return newMonoVertex, err | ||
| } | ||
| } | ||
| return newMonoVertex, nil |
There was a problem hiding this comment.
Thanks for doing this. Just FYI that Chandan will be working on an issue soon to avoid having to do too many of these conversions in the code.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
juliev0
approved these changes
Oct 24, 2024
whynowy
added a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Modifications
When reconciling a MonoVertexRollout object, use the
replicasfrom existing MonoVertex object if it has.Verification
Created a MonoVertexRollout object, manually scaled the orchestrated MonoVertex replicas, the numaplane controller did reconcile the watched notification, but the
replicasvalue in the MonoVertex object remained unchanged.