-
Notifications
You must be signed in to change notification settings - Fork 2
CI: apply gha-update #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updates hashes and appends version numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as an exercise I tried looking up these hashes.
I could not find the action/download-artifact source repo to verify the hash, is it from github itself?
@@ -88,12 +88,12 @@ jobs: | |||
|
|||
steps: | |||
- name: Checkout numpy-release | |||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the hash from https://github.com/actions/checkout/releases/tag/v5.0.0
@@ -149,7 +149,7 @@ jobs: | |||
echo "CIBW_PLATFORM=pyodide" >> "$GITHUB_ENV" | |||
|
|||
- name: Build wheels | |||
uses: pypa/cibuildwheel@c923d83ad9c1bc00211c5041d0c3f73294ff88f6 | |||
uses: pypa/cibuildwheel@c923d83ad9c1bc00211c5041d0c3f73294ff88f6 # v3.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the hash from https://github.com/pypa/cibuildwheel/releases/tag/v3.1.4
@@ -169,7 +169,7 @@ jobs: | |||
- name: install micromamba | |||
# win-arm64 is unsupported by micromamba at the moment | |||
if: github.event_name == 'schedule' && matrix.buildplat[1] != 'win_arm64' | |||
uses: mamba-org/setup-micromamba@b09ef9b599704322748535812ca03efb2625677b | |||
uses: mamba-org/setup-micromamba@b09ef9b599704322748535812ca03efb2625677b # v2.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the hash from https://github.com/mamba-org/setup-micromamba/releases/tag/v2.0.5
@@ -288,12 +288,12 @@ jobs: | |||
id-token: write # mandatory for trusted publishing | |||
steps: | |||
- name: Download sdist and wheels | |||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v.4.3.0 | |||
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not actually find this action, do you know where to verify the hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: | ||
path: dist | ||
|
||
- name: Publish | ||
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 | ||
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the hash from https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.12.4
Thanks @andyfaff |
updates hashes and appends version numbers