Skip to content

Conversation

andyfaff
Copy link
Member

updates hashes and appends version numbers

updates hashes and appends version numbers
Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as an exercise I tried looking up these hashes.

I could not find the action/download-artifact source repo to verify the hash, is it from github itself?

@@ -88,12 +88,12 @@ jobs:

steps:
- name: Checkout numpy-release
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -149,7 +149,7 @@ jobs:
echo "CIBW_PLATFORM=pyodide" >> "$GITHUB_ENV"

- name: Build wheels
uses: pypa/cibuildwheel@c923d83ad9c1bc00211c5041d0c3f73294ff88f6
uses: pypa/cibuildwheel@c923d83ad9c1bc00211c5041d0c3f73294ff88f6 # v3.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -169,7 +169,7 @@ jobs:
- name: install micromamba
# win-arm64 is unsupported by micromamba at the moment
if: github.event_name == 'schedule' && matrix.buildplat[1] != 'win_arm64'
uses: mamba-org/setup-micromamba@b09ef9b599704322748535812ca03efb2625677b
uses: mamba-org/setup-micromamba@b09ef9b599704322748535812ca03efb2625677b # v2.0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -288,12 +288,12 @@ jobs:
id-token: write # mandatory for trusted publishing
steps:
- name: Download sdist and wheels
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v.4.3.0
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not actually find this action, do you know where to verify the hash?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with:
path: dist

- name: Publish
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip mattip merged commit 3f3fa0d into numpy:main Aug 26, 2025
157 of 158 checks passed
@mattip
Copy link
Member

mattip commented Aug 26, 2025

Thanks @andyfaff

@andyfaff andyfaff deleted the gha-update branch August 26, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants