-
-
Notifications
You must be signed in to change notification settings - Fork 9
Extending the python support to 3.13 and 3.14 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ngoldbaum wheels building and tests are running fine for 3.13 and 3.14, you can have a look (just some small workflow changes) |
I edited the PR description since we would still need to fix the release automation to close #130.
Is this an allusion to free-threaded support? You would need to add 3.13t and 3.14t builds to get free-threaded support. You've only added GIL-enabled 3.13 and 3.14 builds here. I think you'd also need to declare free-threaded support in the extension too, otherwise the GIL will get enabled at runtime. See https://py-free-threading.github.io/porting-extensions/#declaring-free-threaded-support. Probably worth adding |
I see, this make sense. Thanks for the pointers @ngoldbaum, will update the PR here after incorporating and testing this all on personal fork |
It seems the extension needs to be edited here, let's add this too in the tracker to keep the updates |
It seems to be working as expected, @ngoldbaum please take a look
We may need to expand the testing to cover thread-safety better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, now we just need to fix the release automation to make sure the sdist gets uploaded and then do a release! |
You mean within CI uploading sdist along with artifacts for every release? |
yup! The wheels and sdist should be uploaded together once they're all built. I can point you at some examples in other repos if you need one. |
towards fixing #130