A change to the field returned from the TE to use for column_name. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine. A TypeObject is needed instead of returning None. As
None is used to verify that the type returned is in the TYPEMAP.
cursor.execute('select NULL from DUAL')
fails without this change. I don't know how TypeObject is used an rather
there is a side-effect by using TypeObject(None) and any use of TypeObject.
column_name does not seem to be what we want, use column_label instead. Or the order of these two fields are incorrect from the order that engine is sending the data. Test case nuodb_description_name_test.py shows failure before this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
column_name does not seem to be what we want, use column_label
instead. Or the order of these two fields are incorrect from
the order that engine is sending the data.
Test case nuodb_description_name_test.py shows failure before this change.