forked from se-edu/addressbook-level2
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5.7][W12-4]Victoreen Robert Elliot #450
Open
robertvictoreen
wants to merge
4
commits into
nus-cs2103-AY1819S1:master
Choose a base branch
from
robertvictoreen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package seedu.addressbook.commands; | ||
|
||
/** | ||
* Clears the address book. | ||
*/ | ||
public class SortCommand extends Command { | ||
|
||
public static final String COMMAND_WORD = "sort"; | ||
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Sorts the address book in lexical order.\n" | ||
+ "Example: " + COMMAND_WORD; | ||
|
||
public static final String MESSAGE_SUCCESS = "Address book has been sorted!"; | ||
|
||
@Override | ||
public CommandResult execute() { | ||
addressBook.sort(); | ||
return new CommandResult(MESSAGE_SUCCESS); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,8 @@ | |
|| Example: find alice bob charlie | ||
|| list: Displays all persons in the address book as a list with index numbers. | ||
|| Example: list | ||
|| sort: Sorts the address book in lexical order. | ||
|| Example: sort | ||
|| view: Views the non-private details of the person identified by the index number in the last shown person listing. | ||
|| Parameters: INDEX | ||
|| Example: view 1 | ||
|
@@ -198,6 +200,18 @@ | |
|| Enter command: || [Command entered: viewall 5] | ||
|| Viewing person: Esther Potato Phone: 555555 Email: [email protected] Address: (private) 555, epsilon street Tags: [tubers][starchy] | ||
|| =================================================== | ||
|| Enter command: || [Command entered: sort] | ||
|| Address book has been sorted! | ||
|| =================================================== | ||
|| Enter command: || [Command entered: list] | ||
|| 1. Adam Brown Phone: 111111 Email: [email protected] Address: 111, alpha street Tags: | ||
|| 2. Betsy Choo Tags: [secretive] | ||
|| 3. Charlie Dickson Email: [email protected] Address: 333, gamma street Tags: [school][friends] | ||
|| 4. Dickson Ee Phone: 444444 Address: 444, delta street Tags: [friends] | ||
|| 5. Esther Potato Phone: 555555 Email: [email protected] Tags: [tubers][starchy] | ||
|| | ||
|| 5 persons listed! | ||
|| =================================================== | ||
|| Enter command: || [Command entered: find] | ||
|| Invalid command format! | ||
|| find: Finds all persons whose names contain any of the specified keywords (case-sensitive) and displays them as a list with index numbers. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package seedu.addressbook.commands; | ||
|
||
import static org.junit.Assert.assertTrue; | ||
|
||
import java.util.Collections; | ||
|
||
import org.junit.Test; | ||
|
||
import seedu.addressbook.data.AddressBook; | ||
import seedu.addressbook.data.exception.IllegalValueException; | ||
import seedu.addressbook.util.TypicalPersons; | ||
import seedu.addressbook.util.TestUtil; | ||
|
||
public class SortCommandTest { | ||
|
||
private final TypicalPersons td = new TypicalPersons(); | ||
|
||
@Test | ||
public void execute() throws IllegalValueException { | ||
AddressBook sortedAddressBook; | ||
AddressBook unsortedAddressBook; | ||
|
||
sortedAddressBook = TestUtil.createAddressBook(td.amy, td.bill, td.candy, td.dan); | ||
unsortedAddressBook = TestUtil.createAddressBook(td.bill, td.dan, td.candy, td.amy); | ||
assertSortCommandBehavior(unsortedAddressBook, sortedAddressBook); | ||
|
||
sortedAddressBook = TestUtil.createAddressBook(td.amy, td.bill); | ||
unsortedAddressBook = TestUtil.createAddressBook(td.amy, td.bill); | ||
assertSortCommandBehavior(unsortedAddressBook, sortedAddressBook); | ||
|
||
sortedAddressBook = TestUtil.createAddressBook(); | ||
unsortedAddressBook = TestUtil.createAddressBook(); | ||
assertSortCommandBehavior(unsortedAddressBook, sortedAddressBook); | ||
} | ||
|
||
/** | ||
* Executes the find command for the given keywords and verifies | ||
* the result matches the persons in the expectedPersonList exactly. | ||
*/ | ||
private void assertSortCommandBehavior(AddressBook input, AddressBook expected) { | ||
SortCommand command = createSortCommand(input); | ||
command.execute(); | ||
|
||
assertTrue(input.equals(expected)); | ||
} | ||
|
||
private SortCommand createSortCommand(AddressBook input) { | ||
SortCommand command = new SortCommand(); | ||
command.setData(input, Collections.emptyList()); | ||
return command; | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect comment