Sparsh/IncyBot iP#194
Open
IncyBot wants to merge 22 commits into
Open
Conversation
Jai2501
reviewed
Feb 25, 2024
Jai2501
left a comment
Jai2501
left a comment
There was a problem hiding this comment.
Hi Sparsh!
Good job on the work done so far!
I have reviewed your code and have left some comments. Please go through them and get back to me for any clarifications.
Thanks!
Comment on lines
+5
to
+12
| Scanner scanner = new Scanner(System.in); | ||
| String input; | ||
| Task[] tasks = new Task[100]; | ||
| int taskCount = 0; | ||
| String logo = " ____ _ _ ___ _ _ \n" | ||
| + "(_ _)( \\( )/ __)( \\/ )\n" | ||
| + " _)(_ ) (( (__ \\ / \n" | ||
| + "(____)(_)\\_)\\___) (__) \n"; |
There was a problem hiding this comment.
It is good to specify access modifiers for the variables being declared, like private, public or protected
| public static void main(String[] args) { | ||
| Scanner scanner = new Scanner(System.in); | ||
| String input; | ||
| Task[] tasks = new Task[100]; |
There was a problem hiding this comment.
Please avoid the use of Magic Numbers. Instead declare a constant with the value you deem is right, and use that constant.
Comment on lines
+20
to
+76
| while (true) { | ||
| input = scanner.nextLine(); | ||
| if (input.equalsIgnoreCase("bye")) { | ||
| break; | ||
| } else if (input.equalsIgnoreCase("list")) { | ||
| System.out.println("____________________________________________________________"); | ||
| if (taskCount == 0) { | ||
| System.out.println("Blimey, your list is empty, innit?"); | ||
| } else { | ||
| for (int i = 0; i < taskCount; i++) { | ||
| System.out.println((i + 1) + ". " + tasks[i]); | ||
| } | ||
| } | ||
| System.out.println("____________________________________________________________"); | ||
| } else if (input.startsWith("mark ")) { | ||
| int index = Integer.parseInt(input.substring(5)) - 1; | ||
| if (index >= 0 && index < taskCount) { | ||
| tasks[index].markAsDone(); | ||
| System.out.println("____________________________________________________________\n" | ||
| + "Buzzin'! This one's sorted now:\n " | ||
| + tasks[index] | ||
| + "\n____________________________________________________________" | ||
| ); | ||
| } | ||
| } else if (input.startsWith("unmark ")) { | ||
| int index = Integer.parseInt(input.substring(7)) - 1; | ||
| if (index >= 0 && index < taskCount) { | ||
| tasks[index].markAsNotDone(); | ||
| System.out.println("____________________________________________________________\n" | ||
| + "No prob, flipped it back to not done, innit:\n " | ||
| + tasks[index] | ||
| + "\n____________________________________________________________" | ||
| ); | ||
| } | ||
| } else { | ||
| if (taskCount >= tasks.length) { | ||
| System.out.println("____________________________________________________________\n" | ||
| + "Cor blimey! The list is full to the brim. Can't add more, sorry!" | ||
| + "\n____________________________________________________________" | ||
| ); | ||
| } else { | ||
| tasks[taskCount] = new Task(input); | ||
| taskCount++; | ||
| System.out.println("____________________________________________________________\n" | ||
| + "Sorted! Added: " + input | ||
| + "\n____________________________________________________________" | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| System.out.println("____________________________________________________________\n" | ||
| + "Cya later mate!" | ||
| + "\n____________________________________________________________" | ||
| ); | ||
| scanner.close(); | ||
| } |
There was a problem hiding this comment.
This code block is deeply nested, and needs to be worked on.
In general, this method is too long, and it is preferred for methods to be shorter than 30 lines of code.
Please work on abstracting this chunk of code.
References:
Added Level-5 and Handled Exceptions
Added delete Functionality
Added Save Functionality
Taught The Chatbot How to Understand DATES
Added JavaDoc comments to the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.