Audit projectM and fix float range safety in evaluator - #5
nutzclub-dev wants to merge 3 commits into
Conversation
Fix float range protections in projectm-eval for modulo, bitwise, and random operations to prevent undefined behavior from NaN or Infinity float-to-integer casts. Update audit report. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fix float range protections in projectm-eval for modulo, bitwise, and random operations to prevent undefined behavior from NaN or Infinity float-to-integer casts. Clean up GPU shader program handles on link error in Shader.cpp and update audit_report.md. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Fix float range checks in projectm-eval for modulo, bitwise, and random operations to avoid undefined behavior from NaN/Inf. - Add glDeleteProgram cleanup on shader program link failure in Shader.cpp. - Update GitHub Actions workflow files to use actions/checkout@v4 and actions/upload-artifact@v4 to fix CI failures. - Update audit_report.md with complete details. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
2 participants
Audited projectM codebase and applied float range checks in vendor/projectm-eval for modulo, bitwise, and random ops when dealing with NaN/Inf values, preserving current custom version behavior and updating audit_report.md.
PR created automatically by Jules for task 8374489733996768970 started by @codeboxqc