Skip to content

GH-313: Layout definitions from patterns lack id property #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

GH-313: Layout definitions from patterns lack id property #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/ui_patterns_layouts/ui_patterns_layouts.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ function ui_patterns_layouts_layout_alter(&$definitions) {
// @todo: Use layout deriver instead.
// @link https://github.com/nuvoleweb/ui_patterns/issues/94
foreach (UiPatterns::getPatternDefinitions() as $pattern_definition) {
$id = 'pattern_' . $pattern_definition->id();
$definition = [
'id' => $id,
'label' => $pattern_definition->getLabel(),
'theme' => $pattern_definition->getThemeHook(),
'provider' => $pattern_definition->getProvider(),
Expand All @@ -33,7 +35,7 @@ function ui_patterns_layouts_layout_alter(&$definitions) {
foreach ($pattern_definition->getFields() as $field) {
$definition['regions'][$field->getName()]['label'] = $field->getLabel();
}
$definitions['pattern_' . $pattern_definition->id()] = new LayoutDefinition($definition);
$definitions[$id] = new LayoutDefinition($definition);
}
}

Expand Down